Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run3-hcx376Z Updated hcalRecNumbering XML files in view of the modified Era dependent topology modes #46374

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Run3-hcx376Z Updated hcalRecNumbering XML files in view of the modified Era dependent topology modes #46374

merged 1 commit into from
Oct 15, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Updated hcalRecNumbering XML files in view of the modified Era dependent topology modes

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

May be backported to 14_1_X

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Oct 14, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46374/42219

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Geometry/HcalCommonData (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Oct 14, 2024
Backprt the changes made to the HcalTopolog class and addadditional h…
29b1a3e 
…calRecoNumbering constansts fom cms-sw#46357, cms-sw#46369, cms-sw#46374
@bsunanda bsunanda mentioned this pull request Oct 14, 2024
Merged
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f14999/42167/summary.html
COMMIT: c878930
CMSSW: CMSSW_14_2_X_2024-10-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46374/42167/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 672e31f into cms-sw:master Oct 15, 2024
11 checks passed
cmsbuild added a commit that referenced this pull request Oct 15, 2024
@cmsbuild
Merge pull request #46381 from bsunanda/Run3-hcx377
9864fcb 
Run3-hcx377 Backport the changes made to the HcalTopolog class and additional hcalRecoNumbering constants from #46357, #46369, #46374
@cmsbuild cmsbuild mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed geometry-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
3 participants
@bsunanda @cmsbuild @mandrenguyen